Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump preact from 10.24.3 to 10.25.0 #1797

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 25, 2024

Bumps preact from 10.24.3 to 10.25.0.

Release notes

Sourced from preact's releases.

10.25.0

Features

Move per-element type interfaces into core and more strictly type IntrinsicElements (#4546, thanks @​rschristian)

This adds per-element typings for every DOM-node type, this means that our types might become slightly stricter when you are using DOM attributes/properties where they are not allowed, an example of this might be <div src="x" />.

If you notice any issues when upgrading tell us about them, we can evaluate whether we have missed a case.

Recreate unkeyed functional components when they change position. (#4550, thanks @​JoviDeCroock)

This is a long time bugfix, when we have elements that look like

return (
	{condition ? <Element /> : null}
	{condition ? null : <Element />
)

We would reuse the state of the first VNode to render the second one when the condition switches. When you are using key, this issue was not present.

Support { handleEvent() {} } object interface as a listener (#4538, thanks @​lilnasy)

We've added support for attaching object/class event-handlers

let handler = {
	onclick,
	handleEvent() {
		this.onclick()
	}
}
<div onClick={handler} />

Fixes

Maintenance

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [preact](https://github.com/preactjs/preact) from 10.24.3 to 10.25.0.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](preactjs/preact@10.24.3...10.25.0)

---
updated-dependencies:
- dependency-name: preact
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 25, 2024
@acelaya
Copy link
Contributor

acelaya commented Nov 28, 2024

The type issues seem to be caused by this refactor in preact preactjs/preact#4546

They have been reported and some have been fixed already (see preactjs/preact#4574 for example), so I guess there will be a v10.25.1 soon.

@rschristian
Copy link
Contributor

rschristian commented Nov 29, 2024

We have a few things we need to figure out before 10.25.1, I'm afraid.

Will try to take a look through here to figure out if there's any not yet fixed. 10.25 was a big change & long asked for, but has a lot of surface area for issues. Certainly let us know if you spot anything that looks weird, we'd love to get that corrected.

Edit:

It looks like many of the issues are due to using types in the form of JSX.HTMLAttributes<HTMLInputElement>, such as here. These all should be switched to JSX.InputHTMLAttributes<HTMLInputElement>, at least where we do have per-element attribute interfaces. Basically matching up against IntrinsicElements.

Sorry, this might end up a bit of work but should be much better types for the effort. I'll see if I can get some of them together tonight.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 2, 2024

Looks like preact is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Dec 2, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/preact-10.25.0 branch December 2, 2024 09:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants