Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JPEG images broken on extension welcome page #8952

Open
robertknight opened this issue Sep 14, 2024 · 0 comments · May be fixed by #8953
Open

JPEG images broken on extension welcome page #8952

robertknight opened this issue Sep 14, 2024 · 0 comments · May be fixed by #8953

Comments

@robertknight
Copy link
Member

robertknight commented Sep 14, 2024 •
edited
Loading

After installing the extension in Chrome, I was taken to https://hypothes.is/welcome/5ef269baa70e3d74 and observed broken icons:

h extension welcome

Fortunately Chrome renders the accessible text for the images as a fallback.

The image URLs return 200s but the files are corrupted compared to the source files in h. From a quick glance this looks like it might be the same issue as hypothesis/client@94bd6bb.
robertknight added a commit that referenced this issue Sep 14, 2024
@robertknight
Fix copying of binary files during asset build
283840c 
This fixes another instance of the issue identified in
hypothesis/client#6527.

Fixes #8952
@robertknight robertknight linked a pull request Sep 14, 2024 that will close this issue
Open
robertknight added a commit that referenced this issue Sep 14, 2024
@robertknight
Fix copying of binary files during asset build
685749e 
This fixes another instance of the issue identified in
hypothesis/client#6527.

Fixes #8952
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix copying of binary files during asset build hypothesis/h
1 participant
@robertknight