Fix migration error in token due to missing userid field
#8546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace imports from `h.models` with local ORM classes. The ORM classes in `h.models` assume the DB has the latest schema, which is not the case when running migrations. The new code matches how other migrations work. Fixes #8541
robertknight
force-pushed
the
fix-token-migration-error
branch
from
044224b to
e7fa258
Compare
acelaya
approved these changes
Feb 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace imports from
h.modelswith local ORM classes. The ORM classes inh.modelsassume the DB has the latest schema, which is not the case when running migrations. The new code matches how other migrations work.Fixes #8541
Testing:
I ran
make dband that initially failed with the error mentioned in #8541. After this change I was able to runmake dband it successfully populated thetoken.user_idfield in the DB.