Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add migration to make user.pubid non-nullable #9250

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov force-pushed the add-backfill-migration-for-user-pubid branch 2 times, most recently from f13b2ab to 8b4d859 Compare January 14, 2025 18:13
@mtomilov mtomilov force-pushed the add-migration-to-make-user-pubid-non-nullable branch from d6b2e7e to ac99bbb Compare January 14, 2025 18:14
@mtomilov mtomilov requested a review from marcospri January 14, 2025 18:37
@mtomilov mtomilov force-pushed the add-backfill-migration-for-user-pubid branch from 8b4d859 to df2d1ae Compare January 14, 2025 20:48
@mtomilov mtomilov force-pushed the add-migration-to-make-user-pubid-non-nullable branch from ac99bbb to a63651b Compare January 14, 2025 20:52
@mtomilov mtomilov force-pushed the add-backfill-migration-for-user-pubid branch from df2d1ae to 6f6795e Compare January 15, 2025 12:50
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd give this a try on prod and see how long it takes to those first 100k

Wrong PR!

Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant to approve the backfill one.

@mtomilov mtomilov force-pushed the add-backfill-migration-for-user-pubid branch from 6f6795e to 46d5c36 Compare January 15, 2025 15:07
Base automatically changed from add-backfill-migration-for-user-pubid to main January 15, 2025 15:12
@mtomilov mtomilov force-pushed the add-migration-to-make-user-pubid-non-nullable branch from a63651b to 92dd4a1 Compare January 16, 2025 11:45
@mtomilov mtomilov changed the base branch from main to add-backfill-migration-for-user-pubid-part-4 January 16, 2025 11:46
@mtomilov mtomilov requested a review from marcospri January 16, 2025 11:49
Base automatically changed from add-backfill-migration-for-user-pubid-part-4 to main January 16, 2025 11:57
@mtomilov mtomilov force-pushed the add-migration-to-make-user-pubid-non-nullable branch from 92dd4a1 to b4c32aa Compare January 16, 2025 14:09
@mtomilov mtomilov merged commit 37c7316 into main Jan 16, 2025
10 checks passed
@mtomilov mtomilov deleted the add-migration-to-make-user-pubid-non-nullable branch January 16, 2025 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants