Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a temporary hack to upgrade gevent and greenlet in Docker #714

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

robertknight
Copy link
Member

gevent is used by both uWSGI and pywb. pywb pins it to v22.10.2. However there have been fixes for the version of Python we are using in v24.2.1. In order to test whether the older version of gevent is responsible for hangs we are seeing in production, update gevent in the Docker container.

Testing:

  • Build docker container locally with make docker
  • Run viahtml container with make run-docker
  • Run the local via service using make dev, and check that you can browse to http://localhost:9083/https://example.org/

See also:

gevent is used by both uWSGI and pywb. pywb pins it to v22.10.2. However there
have been fixes for the version of Python we are using in v24.2.1. In order to
test whether the older version of gevent is responsible for hangs we are seeing
in production, update gevent in the Docker container.
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to run fine with some very light testing.

I'd say is worth the risk to rule this out as the main problem.

@robertknight robertknight merged commit 0ce6bb5 into main Sep 16, 2024
4 checks passed
@robertknight robertknight deleted the update-gevent-in-prod branch September 16, 2024 14:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants