Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[hyprlock] Add more description for monitor field #746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[hyprlock] Add more description for monitor field #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pages/Hypr Ecosystem/hyprlock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Variables in the `general` category:
## Keyboard Shortcuts and Actions

The following keys and key-combinations describe hyprlock's default behaviour:
| input | description |
| input | description |
| -- | -- |
| ESC | Clear password buffer |
| Ctrl + u | Clear password buffer |
Expand All @@ -47,7 +47,16 @@ widget_name {
}
```

`monitor` can be left empty for "all monitors"
The `monitor` could be either the __port name__ or __description__ value from
the output of `hyprctl monitors` command. It can be left empty for "all
monitors"

{{< callout >}}

Pay attention! You do not need to add `desc:` prefix like in
[`hyprland.conf`](../Configuring/Monitors.md)

{{</ callout >}}
Comment on lines +54 to +59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not true.

The current check is surf->output->stringDesc.starts_with(c.monitor)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we support prefixing with desc: as well for consistency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desc: variant stops work for me at all. The ripgrep did not find any occurrences of desc: in sources. I found the line @PaideiaDilemma talking about in sources and tries to remove the desc: from config. And it worked.

So I decided to update doc and mention this peculiarity.

I think, we should to add prefix for consistency too, but we should have clear actual documentation as well

Copy link
Contributor

@PaideiaDilemma PaideiaDilemma Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I create a MR in hyprlock to support desc:.

Sorry I initially misunderstood the wording, because i read it too fast. You were of course correct on this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the this section, but the rest is fine.


## Widget List

Expand Down