fix(zap): only record log metrics when we actually log something (#341)

i-love-flamingo · Jul 13, 2023 · b0dca2b · b0dca2b
1 parent f616b5e
commit b0dca2b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/core/silentzap/logger.go b/core/silentzap/logger.go
@@ -161,6 +161,10 @@ func makeFieldMap(configFieldMap config.Map) map[string]string {
 }
 
 func (l *SilentLogger) record(level string) {
+	if !l.Core().Enabled(logLevels[level]) {
+		return
+	}
+
 	ctx, _ := tag.New(context.Background(), tag.Upsert(opencensus.KeyArea, l.configArea), tag.Upsert(keyLevel, level))
 	stats.Record(ctx, logCount.M(1))
 }

diff --git a/core/zap/logger.go b/core/zap/logger.go
@@ -70,6 +70,10 @@ func (l *Logger) WithContext(ctx context.Context) flamingo.Logger {
 }
 
 func (l *Logger) record(level string) {
+	if !l.Core().Enabled(logLevels[level]) {
+		return
+	}
+
 	ctx, _ := tag.New(context.Background(), tag.Upsert(opencensus.KeyArea, l.configArea), tag.Upsert(keyLevel, level))
 	stats.Record(ctx, logCount.M(1))
 }