feat: parse namespace from t
type arguments
#701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
It allows us to use type argument of
t
function (see type definition) to set default namespace when parsing content.This is particularly useful when you are passing
t
from component, for exampleEven though the example above might not be the best use case, it should be good enough to explain how we can benefit from this.
In the case above, you'd normally end up with one translation in
user
namespace and the rest in the default namespace.With the proposed changes, we would parse the function declarations to extract namespace from type arguments of
t
so that all parsed keys end up inuser
namespace.What do you guys think about this? Would it be somewhat helpful? Have you found yourselves dealing with this kind of cases in the past?
Does it fix an existing ticket?
Yes #703
Checklist
yarn test
(see details here)