Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typescript definitions are not tested #654

Closed
rosskevin opened this issue Dec 31, 2018 · 3 comments
Closed

Typescript definitions are not tested #654

rosskevin opened this issue Dec 31, 2018 · 3 comments

Comments

@rosskevin
Copy link
Collaborator

Describe the bug
Downstream in my app, since the types were brought in-repo - I now have typescript problems related to i18next/react-i18next. This may be a local problem, or one with the repo, but without tests in the repo I have no certainty.

Tests were used in the @types/react-i18next but never brought here e.g. react-i18next-tests.tsx

Occurs in react-i18next version
react-i18next ^9.0.0
i18next ^13.1.0

TL;DR

I'm working on a PR with typescript usage tests that will yield some certainty that types will work as represented by examples. With that in place, it will give me confidence and I can focus on potential userland errors in my environment.

@Tsury
Copy link

Tsury commented Jan 1, 2019

Same, getting TS issues:

node_modules/react-i18next/index.d.ts:3:41 - error TS2307: Cannot find module 'create-react-context'.
import { Context as ReactContext } from 'create-react-context';

@rosskevin
Copy link
Collaborator Author

PR is now good to merge.

@jamuhl
Copy link
Member

jamuhl commented Jan 2, 2019

published in react-i18next@9.0.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants