Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add typescript tests with example usage as sanity check and hook into testscript #655

Merged
merged 3 commits into from
Jan 2, 2019

Conversation

rosskevin
Copy link
Collaborator

@rosskevin rosskevin commented Dec 31, 2018

  • Add typescript usage tests for sanity and hook into ci to assist in keeping up to date.
  • Fix several errors in the type definition

Closes #654

@rosskevin
Copy link
Collaborator Author

Note, this test proves and fixes a few errors I am seeing downstream in my app.

ts users are likely broken due to the bad context type import until this is merged and released.

@coveralls
Copy link

coveralls commented Dec 31, 2018

Coverage Status

Coverage remained the same at 75.157% when pulling 5bcf60f on rosskevin:ts-tests into 0bf4437 on i18next:master.

@rosskevin
Copy link
Collaborator Author

I'm still threading through my codebase and finding some fixes, let's hold this until I get a clean run locally. I'll update this issue when ready.

@rosskevin rosskevin changed the title Add typescript tests with example usage as sanity check and hook into testscript HOLD: Add typescript tests with example usage as sanity check and hook into testscript Dec 31, 2018
@rosskevin rosskevin changed the title HOLD: Add typescript tests with example usage as sanity check and hook into testscript Add typescript tests with example usage as sanity check and hook into testscript Jan 1, 2019
@rosskevin
Copy link
Collaborator Author

This PR is ready to merge.

@rosskevin
Copy link
Collaborator Author

@jamuhl if we can get this merged and released, I would appreciate it.

Incorrect types included in-repo are not easily ignored, whereas they are if they are from definitelytyped (just don't include them). This PR fixes a breaking change for ts users and should get us back to working.

@jamuhl jamuhl merged commit 146a6f6 into i18next:master Jan 2, 2019
@jamuhl
Copy link
Member

jamuhl commented Jan 2, 2019

published in react-i18next@9.0.1

@VincentLanglet
Copy link
Contributor

@rosskevin Do you have time to test also the file for hook type ?

You broke them with your PR, cf : #658

@rosskevin
Copy link
Collaborator Author

@VincentLanglet I don't use the hooks yet, but feel free to add usage tests similar to how I did the index.

@rosskevin rosskevin deleted the ts-tests branch January 5, 2019 01:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants