Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added objects explicitly to Trans children #1486

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

high1
Copy link
Contributor

@high1 high1 commented Apr 16, 2022

Fixes #1483.

Allows objects to be passed to Trans component with @types/react@18.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

- this is done because of @types/react@18 - objects now need to be
explicitly allowed
- upgraded to tslint 6.1.3 and disabled the no-null-undefined-union
rule
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.951% when pulling 7382c14 on high1:allow-objects-as-trans-children into 596f60d on i18next:master.

@adrai adrai requested a review from pedrodurek April 16, 2022 14:58
Copy link
Member

@pedrodurek pedrodurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I was in a conference the all week. Looks great to me!

@adrai adrai merged commit 9347070 into i18next:master Apr 19, 2022
@adrai
Copy link
Member

adrai commented Apr 19, 2022

thank you @high1 @pedrodurek, included in v11.16.7

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pass objects to <Trans> with React 18 type definitions
4 participants