Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing type definition for withTranslation options #821

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

maxwkh
Copy link
Contributor

@maxwkh maxwkh commented Apr 10, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.534% when pulling 241bc5e on maxwkh:fix/withTranslationType into 69e4973 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin April 10, 2019 06:08
@jamuhl
Copy link
Member

jamuhl commented Apr 10, 2019

@rosskevin guess this is correct withRef was added in https://github.com/i18next/react-i18next/pull/802/files

@rosskevin
Copy link
Collaborator

Thanks @maxwkh

@jamuhl this can be released as a patch

@rosskevin rosskevin merged commit 001ec04 into i18next:master Apr 10, 2019
@jamuhl
Copy link
Member

jamuhl commented Apr 11, 2019

was published in react-i18next@10.7.0

thank you for providing this...

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants