Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed icon issue #22

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Fixed icon issue #22

merged 3 commits into from
Mar 30, 2024

Conversation

sebe324
Copy link
Contributor

@sebe324 sebe324 commented Mar 30, 2024

obraz

I've added a tag to index.html and removed react-favicon from index.js
I also added ?v=2 to the href to force refresh the favicon.

here is a related stackoverflow thread:
https://stackoverflow.com/questions/2208933/how-do-i-force-a-favicon-refresh

Let me know if it works on your pc

Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for tactictoes ready!

Name Link
🔨 Latest commit 8621c2f
🔍 Latest deploy log https://app.netlify.com/sites/tactictoes/deploys/66088fc8f1b0c60008b18911
😎 Deploy Preview https://deploy-preview-22--tactictoes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sebe324 and others added 2 commits March 30, 2024 18:23
After I refreshed the page it suddenly disappeared? The icon wasn't being found or sth, but it appears to work after i put it in the same directory
@iByteABit256
Copy link
Owner

Nice, thank you!

@iByteABit256 iByteABit256 merged commit e3c3688 into iByteABit256:main Mar 30, 2024
5 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants