Fix register to honor AUTH_PASSWORD_VALIDATORS #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiporox
pushed a commit
to hiporox/dj-rest-auth
that referenced
this pull request
Feb 1, 2022
[`django-allauth` account adapters allow creating a user with no password](https://github.com/pennersr/django-allauth/blob/ced1ddc730c36eca3551406c60e1577e30e01cbd/allauth/account/adapter.py#L241). iMerica#277 broke using this functionality. This PR re-adds it by only running password validation if a password is present in cleaned data
iMerica
pushed a commit
that referenced
this pull request
Feb 6, 2022
* Allow Registration with no password [`django-allauth` account adapters allow creating a user with no password](https://github.com/pennersr/django-allauth/blob/ced1ddc730c36eca3551406c60e1577e30e01cbd/allauth/account/adapter.py#L241). #277 broke using this functionality. This PR re-adds it by only running password validation if a password is present in cleaned data * refactor: change style to match that in allauth * test: add tests * test: fix tests * test: add extra testing to account for coveralls complaints
onlinehub0808
added a commit
to onlinehub0808/dj_rest_auth
that referenced
this pull request
Jan 30, 2023
* Allow Registration with no password [`django-allauth` account adapters allow creating a user with no password](https://github.com/pennersr/django-allauth/blob/ced1ddc730c36eca3551406c60e1577e30e01cbd/allauth/account/adapter.py#L241). iMerica/dj-rest-auth#277 broke using this functionality. This PR re-adds it by only running password validation if a password is present in cleaned data * refactor: change style to match that in allauth * test: add tests * test: fix tests * test: add extra testing to account for coveralls complaints
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old pr, I transferred it:
Tivix/django-rest-auth#482