-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
django-allauth v64 migration #655
Conversation
@iMerica Checking in on the status of this PR? |
|
Can you address merge conflicts? |
@iMerica yes, I can address the merge conflicts. |
…ed from the django-allauth package >= 64.0.0
…n django 4.1 and removed in django>=5.0) with the python datetime module see django documentation here https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-5-0
…onger supported by django or django-allauth) and some minor additional fixes to use of datetime module
3948e3d
to
7e6938b
Compare
@iMerica this is ready for review |
7e6938b
to
32831fa
Compare
Linter:
|
…aware datetime objects
…py and what is currently being installed in CI
…changes in tox and github actions commands
@dan-blanchard I've make the timezone import changes per your docs, thanks for the pointer! @iMerica I've made a few changes to the flake8 configs that align running the linter locally and in the CI.
|
Description
This PR migrates
dj-rest-auth
to the newest major version ofdjango-allauth
. It, unfortunately, forces `dj-rest-auth to increment the major version since it follows django-allauth support for django, and drops support for django < 4.2.Related tickets
closes #646
see also #639
Notes
django.utils.timezone
usage (which was deprecated in django 4.1 and removed in django 5) with the standard library datetime module (see django deprecateion notice here)