Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replace gz_gui_vendor with gz-gui8 #230

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

alsora
Copy link
Contributor

@alsora alsora commented Aug 25, 2024

rosdistro build failed with

Traceback (most recent call last):
  File "/tmp/ros_buildfarm/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 287, in resolve_names
    resolved_names = resolve_for_os(
  File "/usr/lib/python3/dist-packages/rosdep2/catkin_support.py", line 85, in resolve_for_os
    d = view.lookup(rosdep_key)
  File "/usr/lib/python3/dist-packages/rosdep2/lookup.py", line 204, in lookup
    return self.rosdep_defs[rosdep_name]
KeyError: 'gz_gui_vendor'

I think that there are two errors here:

  • it shouldn't be listed as a build tool
  • we should depend on gz-gui8

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
@alsora alsora requested a review from justinIRBT as a code owner August 25, 2024 17:46
@alsora alsora merged commit 1dfea61 into main Aug 25, 2024
1 check passed
@alsora alsora deleted the asoragna/fix-gz-gui-dependency branch August 25, 2024 17:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant