[Refactoring] Split the Extent module into a geographic and a tiled ones #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jailln
reviewed
Sep 26, 2024
jailln
reviewed
Sep 27, 2024
Desplandis
force-pushed
the
refacto/split-extent
branch
from
eabfbca to
198b417
Compare
Desplandis
force-pushed
the
refacto/split-extent
branch
from
198b417 to
e8ac633
Compare
jailln
approved these changes
Oct 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing
Read CONTRIBUTING.md and CODING.md to apply
iTownsconventions on PRs, Git history and code.Description
This PR refactor and split the
Extentmodule into two sub-modules—one for geographic extents (Extent) and one for tiled extents (Tile).Motivation and Context
The current methods of
Extentare all guarded by assertions checking if the current instance is of geographic or tiled type, with a different behavior given the type. Moreover certain methods are only valid for one type. This does not help the tracking of the current type ofExtent.Finally this module currently contributes to at least 25% of all type errors and need a cleaner structure for proper typing.