-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
remove deprecated typography components #1296
Conversation
What was the problem? |
It was for #1298. These typography components don't use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any recommendation for users how to use Text component in their apps? How to add correct padding?
eg. wrap in div or span or something.
Oh, do you mean the /cc @FlyersPh9 |
Yeah, when user wants to add padding at the bottom of |
It's a bit difficult to even come up with a recommendation. We can't just say something like "add Maybe we can just say "use margin or gap with one of the values from itwinui-variables". |
Lets move the discussion out of PR. It's documentation issue, not this PR. |
Changes
yeet!
I'm working on some repo-wide changes and these were getting in the way.
Testing
N/A
Docs
https://github.com/iTwin/iTwinUI/wiki/iTwinUI-react-v3-migration-guide#typography