Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ar-* meridiem function implementation is wrong #1954

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: ar-* meridiem function implementation is wrong #1954

merged 1 commit into from
Jun 27, 2022

Conversation

notoriousmango
Copy link
Contributor

@notoriousmango notoriousmango commented Jun 19, 2022

close #1727
close #1941

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1954 (043b8ea) into dev (74e82b9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1954   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2064      2064           
  Branches       538       538           
=========================================
  Hits          2064      2064           
Impacted Files Coverage Δ
src/locale/ar-dz.js 100.00% <100.00%> (ø)
src/locale/ar-iq.js 100.00% <100.00%> (ø)
src/locale/ar-kw.js 100.00% <100.00%> (ø)
src/locale/ar-ly.js 100.00% <100.00%> (ø)
src/locale/ar-ma.js 100.00% <100.00%> (ø)
src/locale/ar-sa.js 100.00% <100.00%> (ø)
src/locale/ar-tn.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e82b9...043b8ea. Read the comment docs.

@iamkun iamkun merged commit 3d31611 into iamkun:dev Jun 27, 2022
@iamkun
Copy link
Owner

iamkun commented Jun 27, 2022

Thanks

iamkun pushed a commit that referenced this pull request Jul 19, 2022
## [1.11.4](v1.11.3...v1.11.4) (2022-07-19)

### Bug Fixes

* correct past property in ku (kurdish) locale ([#1916](#1916)) ([74e82b9](74e82b9))
* fix French [fr] local ordinal ([#1932](#1932)) ([8f09834](8f09834))
* fix objectSupport plugin ConfigTypeMap type ([#1441](#1441)) ([#1990](#1990)) ([fd51fe4](fd51fe4))
* fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([#1931](#1931)) ([526f0ae](526f0ae))
* update locale ar-* meridiem function ([#1954](#1954)) ([3d31611](3d31611))
* zh-tw / zh-hk locale ordinal error ([#1976](#1976)) ([0a1bd08](0a1bd08))
@iamkun
Copy link
Owner

iamkun commented Jul 19, 2022

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

BePo65 pushed a commit to BePo65/dayjs that referenced this pull request Aug 6, 2022
## [1.11.4](iamkun/dayjs@v1.11.3...v1.11.4) (2022-07-19)

### Bug Fixes

* correct past property in ku (kurdish) locale ([iamkun#1916](iamkun#1916)) ([74e82b9](iamkun@74e82b9))
* fix French [fr] local ordinal ([iamkun#1932](iamkun#1932)) ([8f09834](iamkun@8f09834))
* fix objectSupport plugin ConfigTypeMap type ([iamkun#1441](iamkun#1441)) ([iamkun#1990](iamkun#1990)) ([fd51fe4](iamkun@fd51fe4))
* fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([iamkun#1931](iamkun#1931)) ([526f0ae](iamkun@526f0ae))
* update locale ar-* meridiem function ([iamkun#1954](iamkun#1954)) ([3d31611](iamkun@3d31611))
* zh-tw / zh-hk locale ordinal error ([iamkun#1976](iamkun#1976)) ([0a1bd08](iamkun@0a1bd08))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
## [1.11.4](iamkun/dayjs@v1.11.3...v1.11.4) (2022-07-19)

### Bug Fixes

* correct past property in ku (kurdish) locale ([#1916](iamkun/dayjs#1916)) ([74e82b9](iamkun/dayjs@74e82b9))
* fix French [fr] local ordinal ([#1932](iamkun/dayjs#1932)) ([8f09834](iamkun/dayjs@8f09834))
* fix objectSupport plugin ConfigTypeMap type ([#1441](iamkun/dayjs#1441)) ([#1990](iamkun/dayjs#1990)) ([fd51fe4](iamkun/dayjs@fd51fe4))
* fix type error to add ordianl property in InstanceLocaleDataReturn and GlobalLocaleDataReturn types ([#1931](iamkun/dayjs#1931)) ([526f0ae](iamkun/dayjs@526f0ae))
* update locale ar-* meridiem function ([#1954](iamkun/dayjs#1954)) ([3d31611](iamkun/dayjs@3d31611))
* zh-tw / zh-hk locale ordinal error ([#1976](iamkun/dayjs#1976)) ([0a1bd08](iamkun/dayjs@0a1bd08))
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arabic locales: Meridiem is reversed ar-iq meridiem function implementation is wrong
2 participants