Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: dictzip test #32

Merged
merged 9 commits into from
Nov 17, 2024
Merged

test: dictzip test #32

merged 9 commits into from
Nov 17, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Nov 4, 2024

Description:

Add tests for dictzip files.

Related Issues:

N/A

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 14.03509% with 49 lines in your changes missing coverage. Please review.

Project coverage is 40.00%. Comparing base (2d79407) to head (f8ec0d0).

Files with missing lines Patch % Lines
internal/testutil/dict.go 7.54% 49 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   41.89%   40.00%   -1.90%     
==========================================
  Files          11       11              
  Lines         685      735      +50     
==========================================
+ Hits          287      294       +7     
- Misses        361      405      +44     
+ Partials       37       36       -1     
Files with missing lines Coverage Δ
dict/dict.go 79.41% <100.00%> (+4.22%) ⬆️
idx/idx.go 47.74% <100.00%> (ø)
internal/testutil/dict.go 14.77% <7.54%> (-14.96%) ⬇️

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
internal/testutil/dict.go Outdated Show resolved Hide resolved
internal/testutil/dict.go Outdated Show resolved Hide resolved
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 46f632f into main Nov 17, 2024
19 checks passed
@ianlewis ianlewis deleted the dict-tests branch February 5, 2025 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants