Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[bug] CommentScanner is buggy #1520

Closed
ianlewis opened this issue Jul 18, 2024 · 0 comments · Fixed by #1521
Closed

[bug] CommentScanner is buggy #1520

ianlewis opened this issue Jul 18, 2024 · 0 comments · Fixed by #1521
Assignees
@ianlewis
Labels
bug Something isn't working
Milestone
v0.9.0

Comments

@ianlewis
Copy link
Owner

Describe the bug

If I run todos on (for example) cmd/kubeadm/app/apis/kubeadm/v1beta4/types.go in the Kubernetes codebase it should find a TODO on line 225 but it fails to find it.

It seems that the CommentScanner is not finding all comments in the file.

To Reproduce

Run todos cmd/kubeadm/app/apis/kubeadm/v1beta4/types.go in a Kubernetes git checkout.

Expected behavior

todos should print the TODO in its output.
@ianlewis ianlewis added bug Something isn't working triage This issue needs triage labels Jul 18, 2024
@ianlewis ianlewis self-assigned this Jul 18, 2024
@ianlewis ianlewis removed the triage This issue needs triage label Jul 18, 2024
@ianlewis ianlewis added this to the v0.9.0 milestone Jul 18, 2024
ianlewis added a commit that referenced this issue Jul 18, 2024
@ianlewis
fix: TODO comments after multi-line comments.
e98b795 
Fixes an issue where the `TODOScanner.Scan` would return `false` if it
encounters a multi-line comment with no TODOs present in it.

Fixes #1520

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis mentioned this issue Jul 18, 2024
Merged
7 tasks
@ianlewis ianlewis linked a pull request Jul 18, 2024 that will close this issue
fix: TODO comments after multi-line comments. #1521
Merged
7 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ianlewis ianlewis

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

fix: TODO comments after multi-line comments. ianlewis/todos
1 participant
@ianlewis