Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for OCaml nested comments #1630

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Feb 11, 2025

Description:

Add support for OCaml nested comments.

Related Issues:

Fixes #1628

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.

@ianlewis ianlewis linked an issue Feb 11, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (1a53105) to head (cb551fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/scanner/scanner.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   76.55%   76.41%   -0.15%     
==========================================
  Files          19       19              
  Lines        1203     1221      +18     
==========================================
+ Hits          921      933      +12     
- Misses        205      209       +4     
- Partials       77       79       +2     
Files with missing lines Coverage Δ
internal/scanner/languages.go 100.00% <ø> (ø)
internal/scanner/scanner.go 71.42% <75.00%> (-0.26%) ⬇️

Signed-off-by: Ian Lewis <ian@ianlewis.org>
@ianlewis ianlewis force-pushed the 1628-feature-ocaml-nested-comments branch from 25a0e2f to cb551fa Compare February 11, 2025 02:56
@ianlewis ianlewis merged commit 48c7eeb into main Feb 11, 2025
17 checks passed
@ianlewis ianlewis deleted the 1628-feature-ocaml-nested-comments branch February 11, 2025 03:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] OCaml nested comments
1 participant