Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: simple TODO block comment #1634

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Feb 12, 2025

Description:

Fixed a bug where simple TODO block comments (e.g. /* TODO */) were not shown.

Related Issues:

Fixes #1631

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.

@ianlewis ianlewis linked an issue Feb 12, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (9fcc192) to head (1103b92).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
- Coverage   76.56%   76.50%   -0.06%     
==========================================
  Files          19       19              
  Lines        1229     1226       -3     
==========================================
- Hits          941      938       -3     
  Misses        209      209              
  Partials       79       79              
Files with missing lines Coverage Δ
internal/scanner/comment.go 100.00% <ø> (ø)
internal/scanner/scanner.go 71.83% <100.00%> (+0.40%) ⬆️
internal/scanner/state.go 0.00% <ø> (ø)
internal/todos/todos.go 99.15% <100.00%> (-0.06%) ⬇️

@ianlewis ianlewis changed the title simple : fix TODO block comment fix: simple TODO block comment Feb 12, 2025
@ianlewis ianlewis force-pushed the 1631-bug-simple-todo-in-block-comments-not-detected branch from 3ce02aa to 66effe0 Compare February 12, 2025 00:47
Signed-off-by: Ian Lewis <ian@ianlewis.org>
@ianlewis ianlewis force-pushed the 1631-bug-simple-todo-in-block-comments-not-detected branch from 66effe0 to 1103b92 Compare February 12, 2025 00:49
@ianlewis ianlewis merged commit a1ad3b0 into main Feb 12, 2025
17 checks passed
@ianlewis ianlewis deleted the 1631-bug-simple-todo-in-block-comments-not-detected branch February 12, 2025 00:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Simple TODO in block comments not detected
1 participant