Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: report all TODOs in a multi-line comment #721

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Sep 22, 2023

Description:

Updates the TODO parser to report all TODOs in a multi-line comment.

Related Issues:

Fixes #709

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #721 (37296d3) into main (0832830) will increase coverage by 0.17%.
The diff coverage is 97.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   80.33%   80.50%   +0.17%     
==========================================
  Files          19       19              
  Lines        1129     1144      +15     
  Branches       14       14              
==========================================
+ Hits          907      921      +14     
- Misses        159      160       +1     
  Partials       63       63              
Files Changed Coverage Δ
internal/todos/todos.go 99.16% <97.43%> (-0.84%) ⬇️

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 82cfc85 into main Sep 22, 2023
@ianlewis ianlewis deleted the 709-bug-only-one-todo-is-printed-even-if-multiple-occur-in-multi-line-comments branch September 22, 2023 08:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Only one TODO is printed even if multiple occur in multi-line comments.
1 participant