Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-7147: Fixed issue where multiple Encore entries are applied to ESI fragments #1003

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Nov 22, 2023

This is a workaround to the issue that causes runtime.js to be applied on all ESI fragments.

Requires: https://github.com/ibexa/dashboard/pull/45

@webhdx webhdx added the Bug Something isn't working label Nov 22, 2023
@webhdx webhdx requested a review from dew326 November 22, 2023 14:07
@webhdx webhdx self-assigned this Nov 22, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with local varnish instance built via ibexa/docker.

@alongosz alongosz changed the title Fixed issue where multiple Encore entries are applied to ESI fragments IBX-7147: Fixed issue where multiple Encore entries are applied to ESI fragments Nov 22, 2023
@webhdx webhdx merged commit 973b866 into main Nov 23, 2023
24 of 25 checks passed
@webhdx webhdx deleted the encore_esi_render branch November 23, 2023 11:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants