IBX-7055: Removed unused method #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Nov 27, 2023
Steveb-p
reviewed
Nov 27, 2023
mikadamczyk
force-pushed
the
IBX-7067-fixed-flash-message
branch
from
b42ac92 to
cb91b26
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mikadamczyk
changed the title
alongosz
approved these changes
Dec 5, 2023
Steveb-p
approved these changes
Dec 5, 2023
adamwojs
approved these changes
Dec 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different approach was merged but it is still worth to merge it. It removes an unused method and reduces the number of phpstan errors.
When the Exception is thrown and the content item is not sent to Trash then a proper flash message should be displayedChecklist:
$ composer fix-cs)