Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-7606: [Site context] Site dropdown changes width after entering a search term #1137

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7606
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).


const { offsetWidth, style } = this.dropdown.itemsContainer;

style.width = `${offsetWidth}px`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove it on hide or reset it in case a new element is added?

@GrabowskiM GrabowskiM force-pushed the IBX-7606-dropdown-width-in-filter branch from 917737d to 68fd52b Compare January 31, 2024 09:20
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GrabowskiM GrabowskiM requested a review from tischsoic January 31, 2024 09:26
@adamwojs adamwojs merged commit a521d05 into main Feb 5, 2024
22 checks passed
@adamwojs adamwojs deleted the IBX-7606-dropdown-width-in-filter branch February 5, 2024 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants