-
Notifications
You must be signed in to change notification settings - Fork 18
IBX-9519: [Behat] Added basic test coverage for content tree #1497
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
ad25b6a
to
9ed7408
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first behat tests! 😄
It seems that these scenarios might be missing a direct verification if the content tree is visible and what it includes. Currently, only the content view is being verified, and there is a possibility that the check might pass even if, for some reason, the content tree is not displayed. I would suggest adding some new steps to check what is visible in the content tree.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juskora What do we need in order to finalize this PR ?
use Ibexa\Behat\Browser\Locator\VisibleCSSLocator; | ||
|
||
|
||
class ContentTree extends Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class ContentTree extends Component | |
final class ContentTree extends Component |
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
78c59aa
to
0c87681
Compare
|
A new PR created: #1685 |
| 🎫 Issue |https://issues.ibexa.co/browse/IBX-9519|
Description:
Further development plans:
For QA:
Documentation: