-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
IBX-4629: Implement Meta field groups #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good contribution 👍 I have only some small complaints.
src/bundle/DependencyInjection/Configuration/Parser/AdminUiForms.php
Outdated
Show resolved
Hide resolved
tests/bundle/DependencyInjection/Configuration/Parser/AdminUiFormsTest.php
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/components/meta_fields.html.twig
Show resolved
Hide resolved
SonarCloud Quality Gate failed.
|
@barw4 two questions: |
|
@micszo adding to my previous comment, basically, this PR allows us to additionally add field groups to the Meta tab. Previously we allowed only field types, now we allow to put field groups there as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on Ibexa Commerce 4.3.3-dev.
Encountered an JS issue with subcategory anchors highlighting but managed to reproduce it without these changes. Will be reported separately - update: so far deterministic steps were not found 😞.
Behat tests adjusted here and in https://github.com/ibexa/workflow/pull/70.
A new configuration has been implemented that allows configuring fieldgroups that would be shown in the "Meta" section in the content form:
The default value is set to
metadata
, however, one can configure it to include any of available fieldgroups or even disable this feature:The
meta_fieldgroup_list
configuration is not deeply merged so overriding it is simple.Also, a minor bug fix was done in order to scroll to a chosen field via an anchor on the left.
Example:
Using a fresh Ibexa DXP installation and the following meta configuration:
with

short_name
being changed toMetadata
fieldgroup, andtaxonomy_entry_assignment
being set tometa: true
, one can observe the following:One last thing worth mentioning is that
meta: true
configuration still applies, so we should decide whether to disable it for thetaxonomy
and theproduct_catalog
packages and allows developers to decide whether to apply it themselves or leave it as it is for now with an annotation in the Developer Documentation.// Edit - will be removed from both those packages, however, this configuration still is valid.
Short summary, both the
meta_field_groups_list
and themeta: true
configurations are valid.Related PRs:
Checklist:
$ composer fix-cs
)