IBX-4929: ChangeOwnerLimitationMapper: Fix phpDoc #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
adriendupuis
changed the title
konradoboza
approved these changes
Mar 29, 2023
webhdx
approved these changes
Mar 29, 2023
mikadamczyk
approved these changes
Mar 29, 2023
mikadamczyk
reviewed
Mar 29, 2023
Steveb-p
approved these changes
Mar 29, 2023
kisztof
approved these changes
Mar 30, 2023
Fix ChangeOwnerLimitationMapper::getSelectionChoices phpDoc Unable to parse file "vendor/ibexa/admin-ui/src/lib/Limitation/Mapper/ChangeOwnerLimitationMapper.php", an error was detected: An array can have only integers or strings as keys When used as key, `null` is casted to an empty string. `ChangeOwnerLimitation::LIMITATION_VALUE_SELF` should never be `null`.
adriendupuis
force-pushed
the
fix-phpdoc
branch
from
8805316 to
e087df9
Compare
@mikadamczyk I rebased on |
|
Kudos, SonarCloud Quality Gate passed!
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ChangeOwnerLimitationMapper::getSelectionChoices phpDoc by removing the possibility for the key to be
null.From phpDocumentor v3.3.1:
Unable to parse file "vendor/ibexa/admin-ui/src/lib/Limitation/Mapper/ChangeOwnerLimitationMapper.php", an error was detected: An array can have only integers or strings as keysnullis casted to an empty string so it can't be a key.ChangeOwnerLimitation::LIMITATION_VALUE_SELFshould never benull.Checklist:
$ composer fix-cs)