Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZEE-3213: Added verification if the user has section/view permission #78

Merged
merged 4 commits into from
Dec 2, 2021
Merged

EZEE-3213: Added verification if the user has section/view permission #78

merged 4 commits into from
Dec 2, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Dec 1, 2021 •
edited
Loading

Question Answer
Tickets EZEE-3213
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Merge up from: ezsystems/ezplatform-admin-ui#2016

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Dec 1, 2021
@mateuszdebinski mateuszdebinski requested a review from a team December 1, 2021 11:14
@mateuszdebinski mateuszdebinski self-assigned this Dec 1, 2021
@dew326
Copy link
Contributor

dew326 commented Dec 1, 2021

Are you sure it was created according to our standards? Usually, such cross merges have merge commit.

@bogusez bogusez self-assigned this Dec 1, 2021
@mateuszdebinski mateuszdebinski changed the title IBX-1465: Prioritize current site access when choosing language EZEE-3213: Added verification if the user has section/view permission Dec 2, 2021
Mateusz Dębiński added 2 commits December 2, 2021 12:22
@bogusez bogusez removed their assignment Dec 2, 2021
dew326
dew326 requested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a proper cross merge.
Discussed in private, request changes to block merging.

kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA - Approved.
Tested on v4

@dew326 dew326 merged commit b3e49a6 into main Dec 2, 2021
@dew326 dew326 deleted the IBX-1465_priority_language_siteaccess_4 branch December 2, 2021 14:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @dew326 @GrabowskiM @lucasOsti @kacper-wieczorek-ibexa @bogusez