IBX-4233: Form Inputs - space between fields #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-4233-form-inputs-margins
branch
from
d101e94 to
b992475
Compare
Gengar-i
approved these changes
May 16, 2023
lucasOsti
approved these changes
May 17, 2023
src/bundle/Resources/views/themes/admin/section/create.html.twig
Outdated
Show resolved
Hide resolved
dew326
approved these changes
May 17, 2023
Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
katarzynazawada
requested changes
May 29, 2023
There was a problem hiding this comment.
@GrabowskiM I found few places that need fix
- Form builder - validation tab
- User account field
- Headers e.g.
- Missing empty space at the bottom of the form
- PB field settings https://recordit.co/zkueyOJ3MS
Fixed |
|
@dew326, should this now go to 4.5 as 4.4 is not supported(EOM in May)? |
|
I think we should do one last release for 4.4 to include all fixes that were merged in May. But this is more to @webhdx |
micszo
approved these changes
Jun 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
https://github.com/ibexa/corporate-account/pull/192
https://github.com/ibexa/form-builder/pull/82
https://github.com/ibexa/page-builder/pull/213
https://github.com/ibexa/personalization/pull/279
https://github.com/ibexa/product-catalog/pull/966
https://github.com/ibexa/segmentation/pull/74
Checklist:
$ composer fix-cs)