Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added removing content type draft when clicking cancel button #846

Closed
wants to merge 1 commit into from
Closed

Added removing content type draft when clicking cancel button #846

wants to merge 1 commit into from

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Jul 21, 2023 •
edited
Loading

Question Answer
Tickets N/A
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR adds removing content type draft when clicking cancel button in create content type process. There is inconsistency between create and update actions. In edit process clicking cancel button removes draft but not in create process.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ciastektk ciastektk marked this pull request as ready for review July 21, 2023 13:32
@ciastektk ciastektk requested a review from a team July 21, 2023 13:33
@ViniTou ViniTou requested a review from a team July 24, 2023 07:00
@konradoboza konradoboza requested a review from a team July 24, 2023 07:05
@alongosz alongosz requested a review from a team July 24, 2023 08:06
@micszo micszo self-assigned this Aug 2, 2023
@micszo
Copy link
Contributor

micszo commented Aug 2, 2023 •
edited
Loading

@ciastektk this fixes this customer request https://issues.ibexa.co/browse/EZP-31460
possibly it should be opened for v3.3

@mateuszbieniek could you confirm?

@mateuszbieniek
Copy link
Contributor

Hi!
@micszo yes, the issue occurs also in v3.3, therefore this fix should also be included there.

@ciastektk
Copy link
Contributor Author

@micszo, @mateuszbieniek: Fix for 3.3: ezsystems/ezplatform-admin-ui#2107

@micszo micszo mentioned this pull request Aug 3, 2023
Closed
@ciastektk
Copy link
Contributor Author

Closed due to:
ezsystems/ezplatform-admin-ui#2107
#859

@ciastektk ciastektk closed this Aug 3, 2023
@ciastektk ciastektk deleted the added-removing-draft-when-clicking-cancel-button branch August 3, 2023 13:13
@micszo micszo mentioned this pull request Aug 4, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@micszo micszo

@ViniTou ViniTou

Labels
Improvement Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ciastektk @micszo @mateuszbieniek @alongosz @ViniTou @konradoboza @mikadamczyk @Nattfarinn @dew326