Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-6315: Edit embedded items #872

Merged
merged 7 commits into from
Oct 19, 2023
Merged

IBX-6315: Edit embedded items #872

merged 7 commits into from
Oct 19, 2023

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Aug 17, 2023

Question Answer
Tickets IBX-6315
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Realated PRs:

Frontend PR's:

Backend PR's:

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from 1f34c0a to da8746b Compare August 22, 2023 14:43
@adamwojs adamwojs changed the title Ibx 6315 ux edit embeded items IBX-6315: ux edit embeded items Aug 25, 2023
@adamwojs adamwojs changed the title IBX-6315: ux edit embeded items IBX-6315: Edit embedded items Aug 25, 2023
@lucasOsti lucasOsti changed the base branch from main to simplify-action-in-edit-mode August 31, 2023 08:55
@tischsoic tischsoic force-pushed the simplify-action-in-edit-mode branch from 0ada79a to 16ecc1b Compare August 31, 2023 12:08
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from 60c8e10 to 8e31e17 Compare September 1, 2023 12:31
@lucasOsti lucasOsti changed the base branch from simplify-action-in-edit-mode to IBX-6315-edit-preview-embedded-items-TEMP September 1, 2023 12:32
@lucasOsti lucasOsti changed the base branch from IBX-6315-edit-preview-embedded-items-TEMP to simplify-action-in-edit-mode September 1, 2023 12:32
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch 4 times, most recently from b9311f3 to 2dc6e9e Compare September 4, 2023 08:41
@tischsoic tischsoic force-pushed the simplify-action-in-edit-mode branch from 76aea15 to 5ffc829 Compare September 4, 2023 09:26
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch 2 times, most recently from ac49197 to 47120ac Compare September 4, 2023 10:22
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from b888211 to 20dace6 Compare October 11, 2023 08:50
@micszo
Copy link
Contributor

micszo commented Oct 13, 2023

As discussed, please add search and scroll to language list in "Edit" pop-up menu. 🙂

@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch 2 times, most recently from 2e1c050 to ab7e6f2 Compare October 17, 2023 08:43
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from ab7e6f2 to 936dec1 Compare October 17, 2023 08:45
@GrabowskiM GrabowskiM self-requested a review October 17, 2023 08:53
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from 760ea35 to b5bf49e Compare October 17, 2023 09:57
@lucasOsti lucasOsti force-pushed the IBX-6315-ux-edit-embeded-items branch from b5bf49e to a9107bb Compare October 17, 2023 09:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found issues (relations multiple, scroll&search) have been addressed.

Targeting block to be handled separately.

QA Approved on Ibexa Commerce 4.6.x-dev.

@micszo micszo removed their assignment Oct 19, 2023
@dew326 dew326 merged commit b942418 into main Oct 19, 2023
@dew326 dew326 deleted the IBX-6315-ux-edit-embeded-items branch October 19, 2023 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.