Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-6230: Fix incorrect CSS selectors in Behat code #873

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Aug 17, 2023

Question Answer
Tickets IBX-6230
Bug fix? no (behat)
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This is the second part of the task (first part is done in ibexa/behat#69 which covers validation for new selectors).

This fixes existing wrong selectors in this repo.

Tests for all PRs combined: ibexa/commerce#348.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@micszo micszo force-pushed the ibx-6230-fix-selectors branch from 4913b54 to 9a7b25f Compare August 21, 2023 11:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo marked this pull request as ready for review August 21, 2023 12:24
@micszo micszo merged commit c636111 into main Aug 23, 2023
@micszo micszo deleted the ibx-6230-fix-selectors branch August 23, 2023 09:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants