Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-5854: Unified cookies names #917

Merged
merged 2 commits into from
Sep 28, 2023
Merged

IBX-5854: Unified cookies names #917

merged 2 commits into from
Sep 28, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Sep 25, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5854
Bug fix? no
New feature? yes
BC breaks? yno
Tests pass? yes
Doc needed? no
License GPL-2.0

https://github.com/ibexa/product-catalog/pull/1070
https://github.com/ibexa/taxonomy/pull/232
https://github.com/ibexa/tree-builder/pull/116

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 self-assigned this Sep 25, 2023
@dew326 dew326 changed the base branch from main to 4.5 September 25, 2023 10:46
mnocon
mnocon requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The width is not restored properly for the ibexa_menu-secondary-width cookie - shoudln't the name begin with ibexa-, not ibexa_?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326
Copy link
Contributor Author

dew326 commented Sep 28, 2023

@mnocon fixed

@dew326 dew326 requested a review from mnocon September 28, 2023 11:28
@ViniTou ViniTou merged commit 4edc98a into 4.5 Sep 28, 2023
@ViniTou ViniTou deleted the unify-cookies branch September 28, 2023 13:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@mnocon mnocon mnocon approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dew326 @GrabowskiM @mnocon @Gengar-i @mikadamczyk @Nattfarinn @ciastektk @ViniTou