Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-6729: Drafts should be removed from user menu #939

Merged
merged 2 commits into from
Oct 19, 2023
Merged

IBX-6729: Drafts should be removed from user menu #939

merged 2 commits into from
Oct 19, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6729
Bug fix? yes
New feature? no
BC breaks? yes
Tests pass? no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-6729-remove-drafts-from-menu branch from d6356f9 to ed4e021 Compare October 10, 2023 11:00
@dew326 dew326 requested a review from a team October 10, 2023 12:37
tischsoic
tischsoic requested changes Oct 13, 2023
View reviewed changes
src/lib/Menu/UserMenuBuilder.php Outdated Show resolved Hide resolved
konradoboza
konradoboza approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 apart from Jakub's comment. Dangling comma will fail on PHP 7.4.

@GrabowskiM GrabowskiM requested a review from tischsoic October 16, 2023 09:00
@GrabowskiM GrabowskiM force-pushed the IBX-6729-remove-drafts-from-menu branch from 1d74281 to e79ec9b Compare October 19, 2023 09:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@katarzynazawada katarzynazawada mentioned this pull request Oct 19, 2023
Closed
@dew326 dew326 merged commit 6accf58 into main Oct 19, 2023
@dew326 dew326 deleted the IBX-6729-remove-drafts-from-menu branch October 19, 2023 12:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@konradoboza konradoboza konradoboza approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@ciastektk ciastektk ciastektk approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees
No one assigned
Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@GrabowskiM @mikadamczyk @ciastektk @tischsoic @dew326 @lucasOsti @konradoboza @katarzynazawada @Gengar-i