Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #71

Merged
merged 2 commits into from
Aug 26, 2024
Merged

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #71

merged 2 commits into from
Aug 26, 2024

Conversation

alongosz
Copy link
Member

🎫 Issue IBX-8138

Description:

Applied rules from Symfony 5 Rector set lists.

For QA:

No QA needed. Regression tests should be enough.

Documentation:

This is code refactoring without behavior change. No documentation changes needed.

Steveb-p
Steveb-p approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of times here types could be narrowed (string instead of string|array, for example) but as this process was automatic and this would require effort for little value, I'll be okay to not address that.

@alongosz alongosz mentioned this pull request Jul 24, 2024
Merged
@alongosz
[Rector] Applied all Symfony 5.x rectors to the production codebase
2c61299 
Applied rules:
 * AddReturnTypeDeclarationRector
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch from 7e0a5ab to 2c61299 Compare August 6, 2024 13:05
@alongosz alongosz mentioned this pull request Aug 20, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs merged commit 5e09f22 into main Aug 26, 2024
7 checks passed
@adamwojs adamwojs deleted the ibx-8138-symfony-5-rule-sets branch August 26, 2024 12:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alongosz @adamwojs @Steveb-p @konradoboza @mikadamczyk @Nattfarinn