-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
IBX-6202: Fixed url alias grouping #248
Conversation
3901e2f
to
56573bc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kisztof we also need to makes sure that it works on the integration level. We can change a bit UrlAliasLookupTest to accept data provider which defines URL Alias name schema, input names, and expected URL Alias. createFolder
would have to be replaced by some custom Content Type so you can set URL Alias name schema.
Alternatively instead of lookup the test can simply load system (auto-generated) URL Aliases and check if the path is correct.
Can be done as a follow-up to speed up QA on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now, thanks!
QA Approved on Ibexa Commerce 4.6.0-dev.
v4.6
This PR fixes URL alias grouping.
Checklist:
$ composer fix-cs
).@ibexa/engineering
).