Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-6314: Applied microcopy guidelines and adjusted translation keys and domains #260

Merged
merged 3 commits into from
Sep 1, 2023
Merged

IBX-6314: Applied microcopy guidelines and adjusted translation keys and domains #260

merged 3 commits into from
Sep 1, 2023

Conversation

tischsoic
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-6314
Type improvement
Target Ibexa version v4.6
BC breaks yes/no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@tischsoic tischsoic mentioned this pull request Aug 9, 2023
Merged
2 tasks
@tischsoic tischsoic marked this pull request as ready for review August 30, 2023 07:39
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
85.2% 85.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alongosz alongosz changed the title IBX-6314: Apply microcopy guidelines and adjust translation keys and domains IBX-6314: Applied microcopy guidelines and adjusted translation keys and domains Sep 1, 2023
@tischsoic tischsoic requested a review from a team September 1, 2023 08:52
@konradoboza konradoboza requested a review from a team September 1, 2023 08:59
@alongosz
Copy link
Member

alongosz commented Sep 1, 2023

Note: SonarCloud duplication issue will be resolved in ezplatform-kernel:1.3 by adding duplication exclusion on _fixture/* files.

@alongosz alongosz merged commit 9f1bdee into main Sep 1, 2023
@alongosz alongosz deleted the fix-translations branch September 1, 2023 09:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tischsoic @alongosz @kisztof @konradoboza @mikadamczyk