IBX-5821: Fixed an issue where incomplete request object was passed over to route Matcher #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5
This PR fixes an issue where an incomplete
Request
object was passed intoUrlMatcher
, because oldRouter::match()
method was called internally whenRouter::matchRequest()
was used.New code mimics the old behavior, but instead of creating an entirely new Request object for matching, it duplicates the existing one (using a built-in method) and replaces
REQUEST_URI
with new path value (the same as used before).I can confirm that both Admin UI and basic front works with this solution.
Tests were updated to more specifically check what values are used by Matcher.
Checklist:
$ composer fix-cs
).@ibexa/engineering
).