Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-7278: Set proper route defaults values #327

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jan 31, 2024

Question Answer
JIRA issue IBX-7278
Type bug
Target Ibexa version v4.6
BC breaks no

Change introduced here: #285 resulted in difference how defaults parameters are provided.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ViniTou ViniTou requested a review from a team January 31, 2024 14:16
@@ -21,6 +21,8 @@ ibexa.content.view:
ibexa.version.preview:
path: /content/versionview/{contentId}/{versionNo}/{language}/site_access/{siteAccessName}
controller: ibexa.controller.content.preview:previewContentAction
defaults:
siteAccessName: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
siteAccessName: null
siteAccessName: ~

is also an option 😅

@alongosz alongosz merged commit 11c8c52 into main Feb 1, 2024
29 checks passed
@alongosz alongosz deleted the ibx-7278-set-route-defaults branch February 1, 2024 09:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants