Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IBX-7689: Modified code to generate hyperlinks only for non-drafts #329

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Feb 5, 2024

Question Answer
JIRA issue IBX-7689
Type bug
Target Ibexa version v4.5
BC breaks no

There is no way to generate valid URL aliases for non-drafts (in \Ibexa\Core\MVC\Symfony\Routing\UrlAliasRouter::generate) and this seems like a simplest solution for this problem.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ViniTou ViniTou changed the base branch from main to 4.5 February 5, 2024 10:06
@ViniTou ViniTou requested a review from a team February 5, 2024 10:06
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested a review from a team February 5, 2024 13:47
@alongosz alongosz added the Bug Something isn't working label Feb 5, 2024
@adamwojs adamwojs merged commit 855d3fd into 4.5 Feb 6, 2024
23 of 28 checks passed
@adamwojs adamwojs deleted the IBX-7689-path-for-draft branch February 6, 2024 16:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants