Skip to content

IBX-9058: Complete REST API Reference #2674

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 20 commits into from
May 15, 2025
Merged

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 14, 2025

Question Answer
JIRA Ticket
Versions master (5.0), 4.6
Edition

Complete REST API Reference entries in parallel with OpenAPI

Previews:

OpenAPI equivalents:

  • ibexa/segmentation#125
  • ibexa/cart#124

Related

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

Preview of modified Markdown: no Markdown change to preview.

@adriendupuis adriendupuis changed the title IBX-9058: Complete REST API Reference IBX-9058: Complete REST API Reference Mar 17, 2025
@adriendupuis adriendupuis marked this pull request as ready for review March 18, 2025 08:43
Copy link

Preview of modified files: no change to preview.

@adriendupuis adriendupuis requested a review from mnocon April 25, 2025 12:55
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this!

@@ -0,0 +1,3 @@
<UserSegmentAssignInput>
<segments>corporate_account</segments>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JSON this part is an array, how to pass multiple segments in XML?

I've tried something like this:

<UserSegmentAssignInput>
    <segments><segment>TestSegment4</segment><segment>TestSegment5</segment></segments>
</UserSegmentAssignInput>

and received:

<?xml version="1.0" encoding="UTF-8"?>
<ErrorMessage media-type="application/vnd.ibexa.api.ErrorMessage+xml">
    <errorCode>406</errorCode>
    <errorMessage>Not Acceptable</errorMessage>
    <errorDescription>Argument 'segments[segment]' is invalid: expected a string</errorDescription>
    <trace>#0 /Users/marek/Desktop/Sites/instance1/vendor/ibexa/rest/src/contracts/Input/ParsingDispatcher.php(111): Ibexa\Bundle\Segmentation\REST\Input\Parser\UserSegmentAssignInput-&gt;parse(Array, Object(Ibexa\Contracts\Rest\Input\ParsingDispatcher))
#1 /Users/marek/Desktop/Sites/instance1/vendor/ibexa/rest/src/contracts/Input/ParsingDispatcher.php(86): Ibexa\Contracts\Rest\Input\ParsingDispatcher-&gt;internalParse(Array, 'application/vnd...')
#2 /Users/marek/Desktop/Sites/instance1/vendor/ibexa/rest/src/lib/Input/Dispatcher.php(115): Ibexa\Contracts\Rest\Input\ParsingDispatcher-&gt;parse(Array, 'application/vnd...'

So maybe it's not possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea.

@adriendupuis adriendupuis merged commit 0ca6945 into master May 15, 2025
5 of 7 checks passed
@adriendupuis adriendupuis deleted the complete-rest-api-ref branch May 15, 2025 09:59
adriendupuis added a commit that referenced this pull request May 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants