Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-6121: Added z-index to toolbar #111

Merged
merged 2 commits into from
Jul 26, 2023
Merged

IBX-6121: Added z-index to toolbar #111

merged 2 commits into from
Jul 26, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-6121
Bug/Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jul 20, 2023
@mateuszdebinski mateuszdebinski requested a review from a team July 20, 2023 12:13
@mateuszdebinski mateuszdebinski self-assigned this Jul 20, 2023
@mateuszdebinski mateuszdebinski changed the base branch from main to 4.5 July 20, 2023 12:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mateuszdebinski mateuszdebinski mentioned this pull request Jul 21, 2023
Merged
4 tasks
@jwibexa jwibexa self-assigned this Jul 25, 2023
jwibexa
jwibexa approved these changes Jul 26, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and validated on 4.5 experience FF and chrome

@konradoboza konradoboza merged commit 560c619 into 4.5 Jul 26, 2023
@konradoboza konradoboza deleted the IBX-6121_the_toolbar_is_overlapped branch July 26, 2023 07:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jwibexa jwibexa jwibexa approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@konradoboza konradoboza

@mateuszdebinski mateuszdebinski

@jwibexa jwibexa

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mateuszdebinski @GrabowskiM @tischsoic @dew326 @lucasOsti @Gengar-i @jwibexa @alongosz @konradoboza