Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-6889: Added custom attributes to links #134

Merged
merged 2 commits into from
Nov 20, 2023
Merged

IBX-6889: Added custom attributes to links #134

merged 2 commits into from
Nov 20, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Nov 14, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-6889
Bug/Improvement no
New feature yes
Target version main
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Nov 14, 2023
@dew326 dew326 requested a review from GrabowskiM November 17, 2023 13:33
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.2% 11.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dew326 dew326 merged commit 84c882a into main Nov 20, 2023
21 of 22 checks passed
@dew326 dew326 deleted the attributes-links branch November 20, 2023 13:27
@MagdalenaZuba MagdalenaZuba added the Doc needed The changes require some documentation label Dec 20, 2023
@julitafalcondusza julitafalcondusza self-assigned this Dec 20, 2023
@julitafalcondusza julitafalcondusza removed the Doc needed The changes require some documentation label Jun 18, 2024
@julitafalcondusza julitafalcondusza mentioned this pull request Jun 18, 2024
Merged
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@Gengar-i Gengar-i Awaiting requested review from Gengar-i

Assignees

@alongosz alongosz

@dew326 dew326

@julitafalcondusza julitafalcondusza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dew326 @GrabowskiM @tischsoic @lucasOsti @alongosz @MagdalenaZuba @julitafalcondusza