Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-7441: Fixed custom attributes in link #140

Merged
merged 1 commit into from
Dec 22, 2023
Merged

IBX-7441: Fixed custom attributes in link #140

merged 1 commit into from
Dec 22, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Dec 21, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7441
Bug/Improvement yes
New feature no
Target version 4.6
BC breaks no
Tests pass yes
Doc needed no

Note: the same issue was with the type number

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Dec 21, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo self-assigned this Dec 22, 2023
@micszo micszo mentioned this pull request Dec 22, 2023
Closed
micszo
micszo approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types "choice", "boolean", "string", "number" work fine now.

@micszo micszo removed their assignment Dec 22, 2023
@dew326 dew326 merged commit 97c1b76 into main Dec 22, 2023
21 checks passed
@dew326 dew326 deleted the link-attrs branch December 22, 2023 14:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@micszo micszo micszo approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dew326 @GrabowskiM @micszo @lucasOsti @Gengar-i @alongosz