fixup! Return attributes node even when none is provided for custom tags

[fsoedjede]

Question	Answer
JIRA issue	IBX-XXXXX
Bug/Improvement	yes
New feature	no
Target version	4.3
BC breaks	no
Tests pass	yes/no
Doc needed	yes/no

With the following configuration

ibexa:
    system:
        default:
            fieldtypes:
                ezrichtext:
                    custom_tags: [mytag]
ibexa_fieldtype_richtext:
     custom_tags:
        mytag:
            template: field_type/ibexa_fieldtype_richtext/custom_tags/mytag.html.twig
            icon: '/assets/field_type/ibexa_fieldtype_richtext/custom_tags/icon/mytag.svg'```

I have an error in JS because no attribute is defined.

The error occures at least at two places:

• https://github.com/ibexa/fieldtype-richtext/blob/v4.3.1/src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js#L173-L177
• https://github.com/ibexa/fieldtype-richtext/blob/v4.3.1/src/bundle/Resources/public/js/CKEditor/custom-tags/inline-custom-tag/inline-custom-tag-ui.js#L115-L119

It's because this.config.attributes is undefined.

This change allows us to make sure that this.config.attributes is always defined.

see: #42 (comment)

TODO:

• Fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dew326]

Hi @fsoedjede, the issue should be fixed in #82

[fsoedjede]

I'm closing this PR then.
I'm not working anymore on the projects in order to test.
Thanks