IBX-5757: Fixed custom classes and attributes on headings #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
reviewed
Jun 6, 2023
src/bundle/Resources/public/js/CKEditor/custom-attributes/custom-attributes-ui.js
Outdated
Show resolved
Hide resolved
GrabowskiM
approved these changes
Jun 6, 2023
lucasOsti
reviewed
Jun 6, 2023
src/bundle/Resources/public/js/CKEditor/custom-attributes/custom-attributes-command.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/CKEditor/custom-attributes/custom-attributes-command.js
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
approved these changes
Jun 7, 2023
Gengar-i
approved these changes
Jun 7, 2023
micszo
approved these changes
Jun 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For doc:
In doc, we have a list of elements that can have custom attributes and classes: https://doc.ibexa.co/en/latest/content_management/rich_text/extend_online_editor/#configure-custom-data-attributes-and-classes
Now in the configuration we have two options, we can define
headingand it will work like it was in the previous versions, the custom classes and attributes will be added to every heading.The second way is to specify custom attributes and classes to a specific heading: 'heading1', 'heading2', 'heading3', 'heading4', 'heading5', 'heading6'.
The more specific key is more important, which means if there will be config for
headingandheading2, theheading2will have custom attributes and classes only from theheading2config and will not inherit any attributes or classes from theheadingconfig.TODO:
$ composer fix-cs).