-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
IBX-6602: Used Content::getThumbnail directly for obtaining thumbnails #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-6602-thumbnails-imprv
branch
from
September 19, 2023 16:12
21d1e95
to
07f69fc
Compare
ViniTou
force-pushed
the
ibx-6602-thumbnails-imprv
branch
from
September 19, 2023 16:19
07f69fc
to
2a66c5a
Compare
Closed
konradoboza
reviewed
Sep 20, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
konradoboza
approved these changes
Sep 20, 2023
kisztof
approved these changes
Sep 20, 2023
webhdx
approved these changes
Sep 20, 2023
2 tasks
tomaszszopinski
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.5 commerce.
bdunogier
approved these changes
Sep 29, 2023
Looks good to me. Great PR description 10/10 :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/IBX-6602
Dropped
ContentThumbnail
resolver usageThere is no need for it, as thumbnails can be obtained directly from Content::getThumbnail or User::getThumbnail.
Done this way, instead of doing user.getContent(), as accessing
content
from user object is deprecated.Fixed UserItem (and UserGroupItem)
As it had
type: "UserItem"
but it was resolved tovalue
it was not UserItem, but actual User object.Added Thumbnail for user object
As it is possible now, to obtain thumbnails by accessing content on user object like this:
accessing content on user is deprecated (since 6,10 ;) ), so new property was added to match php API
Fixed unpacking object to array:
resolve: "@=resolver('ContentTypesFromGroup', {'groupId': value.id})"
This was just not working, and can be tested with